Synchronously update internal sockets length so http.Agent pooling is used #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4650f93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I updated the reproduction in #299 to include more examples and when I install |
lukekarrys
commented
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #299
This is a bit of a hack, but I went with this approach because it allows for all of the native socket pooling behavior in
http.Agentto be used andconnect()to keep it's async signature.The tradeoff is manipulating the internal
socketsdictionary which isreadonly(according to@types/node) and therefore needs a lot of@ts-expect-errorcomments. An alternative approach would require overwriting theaddRequest()method with custom pooling code.The approach in this PR works by synchronously adding a fake socket to the pool so
this.sockets[originName].lengthis accurate before any other requests are added. Then the socket is removed directly afterconnect()finishes.